Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap installation order of Trixi.jl and LibTrixi.jl #192

Merged
merged 9 commits into from
Jun 25, 2024
Merged

Swap installation order of Trixi.jl and LibTrixi.jl #192

merged 9 commits into from
Jun 25, 2024

Conversation

benegee
Copy link
Collaborator

@benegee benegee commented Jun 13, 2024

Does this fix #190 ?

@codecov Codecov
Copy link

codecov bot commented Jun 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.27%. Comparing base (25d7014) to head (a5cb439).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #192   +/-   ##
=======================================
  Coverage   80.27%   80.27%           
=======================================
  Files          19       19           
  Lines         715      715           
  Branches       50       50           
=======================================
  Hits          574      574           
  Misses        137      137           
  Partials        4        4
Flag Coverage Δ
unittests 80.27% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benegee
Copy link
Collaborator Author

benegee commented Jun 14, 2024

I also updated t8code's version to v2.0.0. Should have done that earlier, but it also seems to be necessary with the current version of Trixi.jl.

@benegee benegee requested a review from sloede June 14, 2024 11:16
sloede
sloede requested changes Jun 14, 2024
View reviewed changes
utils/libtrixi-init-julia Show resolved Hide resolved
utils/libtrixi-init-julia Outdated Show resolved Hide resolved
@benegee @sloede
Update utils/libtrixi-init-julia
3767281 
Co-authored-by: Michael Schlottke-Lakemper <[email protected]>
sloede
sloede previously approved these changes Jun 17, 2024
View reviewed changes
@sloede sloede enabled auto-merge (squash) June 17, 2024 09:00
@benegee
Copy link
Collaborator Author

benegee commented Jun 17, 2024

🙄
trixi-framework/Trixi.jl#1865 (which happens to be my own PR) changed the non-public-API nelementsglobal.

What to do? Restrict Trixi.jl version to >=0.7.16?

@sloede
Copy link
Member

sloede commented Jun 17, 2024

🙄 trixi-framework/Trixi.jl#1865 (which happens to be my own PR) changed the non-public-API nelementsglobal.

What to do? Restrict Trixi.jl version to >=0.7.16?

What do you mean? All tests seem to pass?!

@benegee benegee requested a review from sloede June 25, 2024 07:48
@sloede sloede merged commit 25c6128 into main Jun 25, 2024
10 checks passed
@sloede sloede deleted the bg/swap_installation_order branch June 25, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloede sloede sloede approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LibTrixi.jl does not pull in latest Trixi.jl version
2 participants
@benegee @sloede